Scheduler - Refactor Appointments Collection - Resizing by bit-byte0 · Pull Request #34187 · DevExpress/DevExtreme

bit-byte0 · 2026-07-01T10:52:07Z

What

Added appointment resizing (timed + all-day) to the new appointments collection behind the _newAppointments flag with Esc-to-cancel, focus handling, group-bounded drag, and rollback on cancel/failure

How

Extracted the resize math into small pure, unit-tested helpers; added opt-in onCancelByEsc to the Resizable widget; wired it into the new grid appointment with a thin scheduler.ts handler that computes the new dates (timed vs all-day) and updates the appointment, focusing it on resize-start and snapping it back if the update is cancelled/fails

Copilot

Pull request overview

This PR refactors Scheduler appointment resizing by moving resize calculations/config into dedicated helpers, wiring the “new appointments” rendering to use dxResizable, and adding Escape-to-cancel support at the internal Resizable level.

Changes:

Added onCancelByEsc + onResizeCancel flow to internal Resizable, including ESC key handling and cancel/restore logic.
Implemented new Scheduler appointment resizing pipeline (config generation, delta-time calculation, resized date range calculation) and integrated it into scheduler.ts.
Enabled resize handles for grid appointments in the “new appointments” implementation and added/updated Jest coverage for the new behavior.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/devextreme/js/__internal/ui/resizable/resizable.ts	Adds ESC cancellation support and a new cancel action for Resizable.
packages/devextreme/js/__internal/ui/resizable/resizable.test.ts	New unit tests validating ESC-cancel behavior and event firing.
packages/devextreme/js/__internal/scheduler/scheduler.ts	Integrates new resizing logic/config into Scheduler and updates resize start/end handling.
packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resized_dates.ts	New helper to compute resized start/end dates with working-hours correction + TZ offset adjustments.
packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resized_dates.test.ts	Tests for start/end resize date calculations and handle-direction logic.
packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resizable_config.ts	New helper to generate Resizable rules (handles/step/min sizes) based on view model/workspace.
packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_resizable_config.test.ts	Tests for resizable rule generation (vertical/horizontal/reduced/RTL/grouping).
packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_delta_time.ts	New helper to compute resize delta-time from pixel deltas across view types.
packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_delta_time.test.ts	Tests for delta-time calculation across view types and all-day/timeline behavior.
packages/devextreme/js/__internal/scheduler/appointments_new/appointments.ts	Adds `getResizableConfig` hook and passes resize settings into GridAppointmentView.
packages/devextreme/js/__internal/scheduler/appointments_new/appointments.test.ts	Updates test properties to include `getResizableConfig`.
packages/devextreme/js/__internal/scheduler/appointments_new/appointments.focus_controller.ts	Exposes `focusViewItem` to support focusing the resized appointment.
packages/devextreme/js/__internal/scheduler/appointments_new/appointment/grid_appointment.ts	Creates a Resizable instance for grid appointments when resizing is enabled.
packages/devextreme/js/__internal/scheduler/appointments_new/appointment/grid_appointment.test.ts	Tests that resize handles appear/disappear based on `allowResize`.
packages/devextreme/js/__internal/scheduler/tests/appointments_resizing.test.ts	Integration tests for resize handles rendering and focus-on-resize-start in Scheduler.

…ypes

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

… title

…regression)

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

… cached size

…tion

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

…esize-size reset

…cel/failure

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 7 comments.

sjbur · 2026-07-03T12:31:45Z

+  private onAppointmentResizeEnd(e: AppointmentResizeEvent): void {
+    const $element = $(e.element);
+    const settings = this._appointments
+      .getAppointmentSettings($element) as AppointmentItemViewModel;


settings can return undefined here. We should add guard
if (!settings) {
return;
}

to avoid type error in runtime

sjbur · 2026-07-03T12:40:05Z

+  return handles.top;
+};
+
+const correctEndDateByDelta = (


correctStartDateByDelta/correctEndDateByDelta — are they almost the same here?

sjbur · 2026-07-03T12:50:22Z

+    const adapter = new AppointmentAdapter(rawAppointment, this._dataAccessors);
+    const { startDateTimeZone, isRecurrent } = adapter;
+
+    if (!e.handles.top && !isRecurrent) {


in old _getEndResizeAppointmentStartDate there was a guard check for appointment not being allDay. In new method we don't have it. Is it by a choice?

bit-byte0 added 7 commits June 30, 2026 23:22

refactor(scheduler): add resize date math to new appointments collection

bf2f87d

feat(resizable): add onCancelByEsc to cancel resize via Escape

4044279

refactor(scheduler): add resize computation helpers for new appointments

5c9677e

feat(scheduler): render resizable handles on new grid appointments

901090b

feat(scheduler): resize timed appointments in the new collection

87ecab0

feat(scheduler): focus resized appointment on resize start

11b6179

refactor(scheduler): remove unused all-day resize helper

b2aab3d

Copilot AI review requested due to automatic review settings July 1, 2026 10:52

bit-byte0 requested review from a team as code owners July 1, 2026 10:52

bit-byte0 self-assigned this Jul 1, 2026

bit-byte0 added the 26_1 label Jul 1, 2026

Copilot started reviewing on behalf of bit-byte0 July 1, 2026 10:52 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/ui/resizable/resizable.ts

Comment thread packages/devextreme/js/__internal/scheduler/scheduler.ts Outdated

bit-byte0 added 2 commits July 1, 2026 15:45

fix(scheduler): address resize PR review comments

8fc3a6a

fix(resizable): use internal events engine in test to satisfy check-t…

b53bf97

…ypes

Copilot AI review requested due to automatic review settings July 1, 2026 11:56

Copilot started reviewing on behalf of bit-byte0 July 1, 2026 11:56 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/ui/resizable/resizable.test.ts

Comment thread packages/devextreme/js/__internal/scheduler/scheduler.ts

Comment thread packages/devextreme/js/__internal/scheduler/appointments_new/resizing/get_delta_time.test.ts Outdated

bit-byte0 added 2 commits July 1, 2026 16:17

test(scheduler): dispose resizable widgets in test and fix delta test…

9a97fe9

… title

fix(resizable): keep resize on dragend without dragstart (esc-cancel …

8c97a40

…regression)

Copilot AI review requested due to automatic review settings July 1, 2026 14:16

Copilot started reviewing on behalf of bit-byte0 July 1, 2026 14:16 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/scheduler/scheduler.ts

Comment thread packages/devextreme/js/__internal/scheduler/scheduler.ts Outdated

Comment thread packages/devextreme/js/__internal/scheduler/scheduler.ts Outdated

bit-byte0 added 2 commits July 1, 2026 18:45

fix(scheduler): bound appointment resize to scrollable area and reset…

f247dbb

… cached size

feat(scheduler): support all-day appointment resize in the new collec…

e3dcc0b

…tion

Copilot AI review requested due to automatic review settings July 1, 2026 16:08

Copilot started reviewing on behalf of bit-byte0 July 1, 2026 16:09 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread packages/devextreme/js/__internal/ui/resizable/resizable.ts

Comment thread packages/devextreme/js/__internal/scheduler/scheduler.ts

Comment thread packages/devextreme/js/__internal/ui/resizable/resizable.test.ts

refactor(scheduler): type resizable test options and drop redundant r…

0a4957a

…esize-size reset

fix(scheduler): constrain resize to group bounds and roll back on can…

4457b01

…cel/failure

Copilot AI review requested due to automatic review settings July 1, 2026 22:31

Copilot started reviewing on behalf of bit-byte0 July 1, 2026 22:31 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

sjbur reviewed Jul 3, 2026

View reviewed changes

fix(scheduler): guard appointment resize end against missing settings

838d4ae

Uh oh!

Conversation

bit-byte0 commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjbur Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

sjbur Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

sjbur Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bit-byte0 commented Jul 1, 2026 •

edited

Loading